Messages in this thread | | | Date | Thu, 26 Oct 2023 15:22:24 +0300 | From | Andy Shevchenko <> | Subject | Re: [PATCH v1 3/6] ACPI: acpi_video: Remove unnecessary driver_data clear |
| |
On Wed, Oct 25, 2023 at 02:18:03PM +0300, Michal Wilczynski wrote: > Commit > 0d16710146a1 ("ACPI: bus: Set driver_data to NULL every time .add() fails")
It's fine to wrap it here, it's just a restriction in the tag block that one tag == one line. Also I believe the form "The commit" sounds more English :-) as reader knows exact commit we are talking about.
> introduced clearing driver_data every time probe fails, so it's not > necessary to clear it in the probe() callback.
> Remove NULL assignment to driver_data in error path in > acpi_video_bus_add().
This can be one line.
-- With Best Regards, Andy Shevchenko
| |