Messages in this thread | | | Date | Thu, 19 Oct 2023 19:54:29 +0300 | From | Andy Shevchenko <> | Subject | Re: [PATCH v2] iio: bmp280: fix eoc interrupt usage |
| |
On Thu, Oct 19, 2023 at 06:22:09PM +0200, Andreas Klinger wrote: > Only the bmp085 can have an End-Of-Conversion (EOC) interrupt. But the > bmp085 and bmp180 share the same chip id. Therefore it's necessary to > distinguish the case in which the interrupt is set. > > Fix the if statement so that only when the interrupt is set and the chip > id is recognized the interrupt is requested. > > This bug exists since the support of EOC interrupt was introduced.
> Fixes: aae953949651 ("iio: pressure: bmp280: add support for BMP085 EOC interrupt")
As Jonathan already commented, this is part of a tag block below...
> Also add a link to bmp085 datasheet for reference. >
...somewhere here.
> Suggested-by: Sergei Korolev <dssoftsk@gmail.com> > Reviewed-by: Linus Walleij <linus.walleij@linaro.org> > Signed-off-by: Andreas Klinger <ak@it-klinger.de> > --- > v1 -> v2: Remove extra space (seen by Andy)
And seems Jonathan mentioned that this is already fixed in his tree. Did I understand that correctly?
-- With Best Regards, Andy Shevchenko
| |