Messages in this thread | | | Date | Wed, 18 Oct 2023 18:50:22 +0300 | From | Andy Shevchenko <> | Subject | Re: [PATCH] iio: bmp280: fix eoc interrupt usage |
| |
On Wed, Oct 18, 2023 at 05:28:16PM +0200, Andreas Klinger wrote: > Only the bmp085 can have an End-Of-Conversion (EOC) interrupt. But the > bmp085 and bmp180 share the same chip id. Therefore it's necessary to > distinguish the case in which the interrupt is set. > > Fix the if statement so that only when the interrupt is set and the chip > id is recognized the interrupt is requested. > > This bug exists since the support of EOC interrupt was introduced. > Fixes: aae953949651 ("iio: pressure: bmp280: add support for BMP085 EOC interrupt") > > Also add a link to bmp085 datasheet for reference.
...
> - if (irq > 0 || (chip_id == BMP180_CHIP_ID)) { > + if (irq > 0 && (chip_id == BMP180_CHIP_ID)) {
While at it, perhaps drop extra space?
-- With Best Regards, Andy Shevchenko
| |