Messages in this thread | | | Date | Wed, 11 Oct 2023 18:39:37 +0200 | From | Nam Cao <> | Subject | Re: [PATCH] staging: rtl8723bs:Fix coding style errors and warning |
| |
On Wed, Oct 11, 2023 at 01:42:32PM -0300, drosdeck wrote: > Warning found by checkpatch.pl script. Fixes warning replacing printk to > pr_crit and fixes conding style. > > Signed-off-by: Edson Juliano Drosdeck <edson.drosdeck@gmail.com>
You are doing too many different things in a single commit. Try splitting them up: 1 commit change printk -> pr_crit, 1 commit add brackets, etc.
Best regards, Nam
| |