Messages in this thread Patch in this message | | | From | Christophe JAILLET <> | Subject | [PATCH] platform: mellanox: Fix a resource leak in an error handling path in mlxplat_probe() | Date | Sun, 1 Oct 2023 08:20:51 +0200 |
| |
If an error occurs after a successful mlxplat_i2c_main_init(), mlxplat_i2c_main_exit() should be called to free some resources.
Add the missing call, as already done in the remove function.
Fixes: 158cd8320776 ("platform: mellanox: Split logic in init and exit flow") Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> --- This patch is based on comparison between functions called in the remove function and the error handling path of the probe.
For some reason, the way the code is written and function names are puzzling to me. So Review with care! --- drivers/platform/x86/mlx-platform.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/platform/x86/mlx-platform.c b/drivers/platform/x86/mlx-platform.c index 3d96dbf79a72..64701b63336e 100644 --- a/drivers/platform/x86/mlx-platform.c +++ b/drivers/platform/x86/mlx-platform.c @@ -6598,6 +6598,7 @@ static int mlxplat_probe(struct platform_device *pdev) fail_register_reboot_notifier: fail_regcache_sync: mlxplat_pre_exit(priv); + mlxplat_i2c_main_exit(priv); fail_mlxplat_i2c_main_init: fail_regmap_write: fail_alloc: -- 2.34.1
| |