Messages in this thread | ![/](/images/icornerl.gif) | | Date | Tue, 31 Jan 2023 10:20:06 -0500 | Subject | Re: [PATCH v5 06/25] powerpc/secvar: Use sysfs_emit() instead of sprintf() | From | Stefan Berger <> |
| |
On 1/31/23 01:39, Andrew Donnellan wrote: > From: Russell Currey <ruscur@russell.cc> > > The secvar format string and object size sysfs files are both ASCII > text, and should use sysfs_emit(). No functional change. > > Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Signed-off-by: Russell Currey <ruscur@russell.cc> > Signed-off-by: Andrew Donnellan <ajd@linux.ibm.com> > > --- > > v2: New patch (gregkh) > --- > arch/powerpc/kernel/secvar-sysfs.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/powerpc/kernel/secvar-sysfs.c b/arch/powerpc/kernel/secvar-sysfs.c > index 702044edf14d..b786d1005027 100644 > --- a/arch/powerpc/kernel/secvar-sysfs.c > +++ b/arch/powerpc/kernel/secvar-sysfs.c > @@ -35,7 +35,7 @@ static ssize_t format_show(struct kobject *kobj, struct kobj_attribute *attr, > if (rc) > goto out; > > - rc = sprintf(buf, "%s\n", format); > + rc = sysfs_emit(buf, "%s\n", format); > > out: > of_node_put(node); > @@ -57,7 +57,7 @@ static ssize_t size_show(struct kobject *kobj, struct kobj_attribute *attr, > return rc; > } > > - return sprintf(buf, "%llu\n", dsize); > + return sysfs_emit(buf, "%llu\n", dsize); > } > > static ssize_t data_read(struct file *filep, struct kobject *kobj,
Reviewed-by: Stefan Berger <stefanb@linux.ibm.com>
| ![\](/images/icornerr.gif) |