lkml.org 
[lkml]   [2023]   [Jan]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH v2] proc: remove mark_inode_dirty() in .setattr()
Date
procfs' .setattr() has updated i_uid, i_gid and i_mode into proc
dirent, we don't need to call mark_inode_dirty() for delayed
update, remove it.

Signed-off-by: Chao Yu <chao@kernel.org>
---
v2:
- remove mark_inode_dirty() from proc_setattr() and proc_sys_setattr()
as well.
fs/proc/base.c | 1 -
fs/proc/generic.c | 1 -
fs/proc/proc_sysctl.c | 1 -
3 files changed, 3 deletions(-)

diff --git a/fs/proc/base.c b/fs/proc/base.c
index 9e479d7d202b..16236fe9b9fe 100644
--- a/fs/proc/base.c
+++ b/fs/proc/base.c
@@ -699,7 +699,6 @@ int proc_setattr(struct user_namespace *mnt_userns, struct dentry *dentry,
return error;

setattr_copy(&init_user_ns, inode, attr);
- mark_inode_dirty(inode);
return 0;
}

diff --git a/fs/proc/generic.c b/fs/proc/generic.c
index 5f52f20d5ed1..f547e9593a77 100644
--- a/fs/proc/generic.c
+++ b/fs/proc/generic.c
@@ -127,7 +127,6 @@ static int proc_notify_change(struct user_namespace *mnt_userns,
return error;

setattr_copy(&init_user_ns, inode, iattr);
- mark_inode_dirty(inode);

proc_set_user(de, inode->i_uid, inode->i_gid);
de->mode = inode->i_mode;
diff --git a/fs/proc/proc_sysctl.c b/fs/proc/proc_sysctl.c
index 48f2d60bd78a..4e71d18e610e 100644
--- a/fs/proc/proc_sysctl.c
+++ b/fs/proc/proc_sysctl.c
@@ -841,7 +841,6 @@ static int proc_sys_setattr(struct user_namespace *mnt_userns,
return error;

setattr_copy(&init_user_ns, inode, attr);
- mark_inode_dirty(inode);
return 0;
}

--
2.36.1
\
 
 \ /
  Last update: 2023-03-27 00:03    [W:0.027 / U:0.728 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site