Messages in this thread Patch in this message | ![/](/images/icornerl.gif) | | From | Fedor Pchelkin <> | Subject | [PATCH v2 4.19] block: fix and cleanup bio_check_ro | Date | Tue, 31 Jan 2023 16:34:01 +0300 |
| |
From: Christoph Hellwig <hch@lst.de>
commit 57e95e4670d1126c103305bcf34a9442f49f6d6a upstream.
Don't use a WARN_ON when printing a potentially user triggered condition. Also don't print the partno when the block device name already includes it, and use the %pg specifier to simplify printing the block device name.
Signed-off-by: Christoph Hellwig <hch@lst.de> Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com> Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com> Link: https://lore.kernel.org/r/20220304180105.409765-2-hch@lst.de Signed-off-by: Jens Axboe <axboe@kernel.dk> [the formatted string layout is not changed because struct bio hasn't got bi_bdev field in stable branches older than 5.15; generic_make_request is removed as it is unnecessary] Signed-off-by: Fedor Pchelkin <pchelkin@ispras.ru> --- v1->v2: added backport comment
block/blk-core.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/block/blk-core.c b/block/blk-core.c index 80f3e729fdd4..4fbf915d9cb0 100644 --- a/block/blk-core.c +++ b/block/blk-core.c @@ -2179,10 +2179,7 @@ static inline bool bio_check_ro(struct bio *bio, struct hd_struct *part) if (op_is_flush(bio->bi_opf) && !bio_sectors(bio)) return false; - - WARN_ONCE(1, - "generic_make_request: Trying to write " - "to read-only block-device %s (partno %d)\n", + pr_warn("Trying to write to read-only block-device %s (partno %d)\n", bio_devname(bio, b), part->partno); /* Older lvm-tools actually trigger this */ return false; -- 2.34.1
| ![\](/images/icornerr.gif) |