| From | Alexander Potapenko <> | Date | Tue, 31 Jan 2023 12:33:31 +0100 | Subject | Re: [PATCH 09/18] lib/stackdepot: rename hash table constants and variables |
| |
On Mon, Jan 30, 2023 at 9:50 PM <andrey.konovalov@linux.dev> wrote: > > From: Andrey Konovalov <andreyknvl@google.com> > > Give more meaningful names to hash table-related constants and variables: > > 1. Rename STACK_HASH_SCALE to STACK_TABLE_SCALE to point out that it is > related to scaling the hash table.
It's only used twice, and in short lines, maybe make it STACK_HASH_TABLE_SCALE to point that out? :)
> 2. Rename STACK_HASH_ORDER_MIN/MAX to STACK_BUCKET_NUMBER_ORDER_MIN/MAX > to point out that it is related to the number of hash table buckets.
How about DEPOT_BUCKET_... or STACKDEPOT_BUCKET_...? (just bikeshedding, I don't have any strong preference).
> 3. Rename stack_hash_order to stack_bucket_number_order for the same > reason as #2. > > No functional changes. > > Signed-off-by: Andrey Konovalov <andreyknvl@google.com> Reviewed-by: Alexander Potapenko <glider@google.com>
|