| From | Alexander Potapenko <> | Date | Tue, 31 Jan 2023 11:42:56 +0100 | Subject | Re: [PATCH 08/18] lib/stackdepot: reorder and annotate global variables |
| |
On Mon, Jan 30, 2023 at 9:50 PM <andrey.konovalov@linux.dev> wrote: > > From: Andrey Konovalov <andreyknvl@google.com> > > Group stack depot global variables by their purpose: > > 1. Hash table-related variables, > 2. Slab-related variables, > > and add comments. > > Also clean up comments for hash table-related constants. > > Signed-off-by: Andrey Konovalov <andreyknvl@google.com> Reviewed-by: Alexander Potapenko <glider@google.com>
... > +/* Lock that protects the variables above. */ > +static DEFINE_RAW_SPINLOCK(depot_lock); > +/* Whether the next slab is initialized. */ > +static int next_slab_inited; Might be worth clarifying what happens if there's no next slab (see my comment to patch 01).
|