lkml.org 
[lkml]   [2023]   [Jan]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[PATCH] scsi: hptiop: Use sysfs_emit in show function callback
According to Documentation/filesystems/sysfs.rst, show() callback
function should only use sysfs_emit() or sysfs_emit_at() instead
of sprint() family functions when formatting the device attribute
values to be returned to user space.
Issue identified using the device_attr_show.cocci Coccinelle script.

Signed-off-by: Deepak R Varma <drv@mailo.com>
---
drivers/scsi/hptiop.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/scsi/hptiop.c b/drivers/scsi/hptiop.c
index 7e8903718245..a92998dd77a6 100644
--- a/drivers/scsi/hptiop.c
+++ b/drivers/scsi/hptiop.c
@@ -1111,7 +1111,7 @@ static int hptiop_adjust_disk_queue_depth(struct scsi_device *sdev,
static ssize_t hptiop_show_version(struct device *dev,
struct device_attribute *attr, char *buf)
{
- return snprintf(buf, PAGE_SIZE, "%s\n", driver_ver);
+ return sysfs_emit(buf, "%s\n", driver_ver);
}

static ssize_t hptiop_show_fw_version(struct device *dev,
@@ -1120,11 +1120,11 @@ static ssize_t hptiop_show_fw_version(struct device *dev,
struct Scsi_Host *host = class_to_shost(dev);
struct hptiop_hba *hba = (struct hptiop_hba *)host->hostdata;

- return snprintf(buf, PAGE_SIZE, "%d.%d.%d.%d\n",
- hba->firmware_version >> 24,
- (hba->firmware_version >> 16) & 0xff,
- (hba->firmware_version >> 8) & 0xff,
- hba->firmware_version & 0xff);
+ return sysfs_emit(buf, "%d.%d.%d.%d\n",
+ hba->firmware_version >> 24,
+ (hba->firmware_version >> 16) & 0xff,
+ (hba->firmware_version >> 8) & 0xff,
+ hba->firmware_version & 0xff);
}

static struct device_attribute hptiop_attr_version = {
--
2.34.1


\
 
 \ /
  Last update: 2023-03-27 00:02    [W:0.047 / U:0.096 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site