Messages in this thread Patch in this message | | | From | Yan Cangang <> | Subject | [PATCH] tty:pty: move wake_up*() after tty_vhangup() in pty_close() | Date | Fri, 27 Jan 2023 15:20:17 +0800 |
| |
wake_up_interruptible() may wake up the session leader blocked on pts, at this time the tty_signal_session_leader() in __tty_hangup() has not been executed.
The session leader's subsequent IO on pts will fail, but the session leader did not received SIGHUP as expected at this time.
A observed phenomenon is that when the ssh connection is disconnected, the background jobs managed by bash did not terminate as expected. This problem is more easily observed on low-end single-processor systems.
Signed-off-by: Yan Cangang <nalanzeyu@gmail.com> --- drivers/tty/pty.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/tty/pty.c b/drivers/tty/pty.c index 07394fdaf522..fbcf2caa8fc1 100644 --- a/drivers/tty/pty.c +++ b/drivers/tty/pty.c @@ -64,8 +64,6 @@ static void pty_close(struct tty_struct *tty, struct file *filp) if (!tty->link) return; set_bit(TTY_OTHER_CLOSED, &tty->link->flags); - wake_up_interruptible(&tty->link->read_wait); - wake_up_interruptible(&tty->link->write_wait); if (tty->driver->subtype == PTY_TYPE_MASTER) { set_bit(TTY_OTHER_CLOSED, &tty->flags); #ifdef CONFIG_UNIX98_PTYS @@ -78,6 +76,8 @@ static void pty_close(struct tty_struct *tty, struct file *filp) #endif tty_vhangup(tty->link); } + wake_up_interruptible(&tty->link->read_wait); + wake_up_interruptible(&tty->link->write_wait); } /* -- 2.30.2
| |