Messages in this thread | | | Date | Mon, 2 Jan 2023 19:27:05 +0200 | From | Andy Shevchenko <> | Subject | Re: [PATCH v8 3/4] fpga: dfl: add basic support for DFHv1 |
| |
On Mon, Jan 02, 2023 at 08:54:48AM -0800, matthew.gerlach@linux.intel.com wrote: > On Thu, 29 Dec 2022, Andy Shevchenko wrote: > > On Thu, Dec 29, 2022 at 08:18:03AM -0800, Tom Rix wrote: > > > On 12/28/22 10:16 AM, matthew.gerlach@linux.intel.com wrote:
...
> > > > + u64 params[]; > > > u64 *params
> > This will break the overflow.h macros, no? > > Besides that it will break the code for sure as it's not an equivalent.
> I don't understand how this will break the overflow.h macros. The definition > of struct dfl_feature_info and all of its uses are in a single file, dfl.c.
Hint: __must_be_array()
As I said, the proposed change is not acceptable since it's not an equivalent.
-- With Best Regards, Andy Shevchenko
| |