Messages in this thread | | | Date | Mon, 2 Jan 2023 08:54:48 -0800 (PST) | From | matthew.gerlach@linux ... | Subject | Re: [PATCH v8 3/4] fpga: dfl: add basic support for DFHv1 |
| |
On Thu, 29 Dec 2022, Andy Shevchenko wrote:
> On Thu, Dec 29, 2022 at 08:18:03AM -0800, Tom Rix wrote: >> On 12/28/22 10:16 AM, matthew.gerlach@linux.intel.com wrote: > > ... > >>> struct dfl_feature_info { >>> u16 fid; >>> u8 revision; >>> + u8 dfh_version; >>> struct resource mmio_res; >>> void __iomem *ioaddr; >>> struct list_head node; >>> unsigned int irq_base; >>> unsigned int nr_irqs; >>> + unsigned int param_size; >>> + u64 params[]; >> u64 *params > > This will break the overflow.h macros, no? > Besides that it will break the code for sure as it's not an equivalent. > >>> };
I don't understand how this will break the overflow.h macros. The definition of struct dfl_feature_info and all of its uses are in a single file, dfl.c.
Matthew Gerlach
> > > -- > With Best Regards, > Andy Shevchenko > > >
| |