Messages in this thread Patch in this message | | | From | Ahmad Fatoum <> | Subject | [PATCH net] net: dsa: microchip: fix probe of I2C-connected KSZ8563 | Date | Thu, 19 Jan 2023 14:10:15 +0100 |
| |
Starting with commit eee16b147121 ("net: dsa: microchip: perform the compatibility check for dev probed"), the KSZ switch driver now bails out if it thinks the DT compatible doesn't match the actual chip:
ksz9477-switch 1-005f: Device tree specifies chip KSZ9893 but found KSZ8563, please fix it!
Problem is that the "microchip,ksz8563" compatible is associated with ksz_switch_chips[KSZ9893]. Same issue also affected the SPI driver for the same switch chip and was fixed in commit b44908095612 ("net: dsa: microchip: add separate struct ksz_chip_data for KSZ8563 chip").
Reuse ksz_switch_chips[KSZ8563] introduced in aforementioned commit to get I2C-connected KSZ8563 probing again.
Fixes: eee16b147121 ("net: dsa: microchip: perform the compatibility check for dev probed") Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de> --- drivers/net/dsa/microchip/ksz9477_i2c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/dsa/microchip/ksz9477_i2c.c b/drivers/net/dsa/microchip/ksz9477_i2c.c index c1a633ca1e6d..e315f669ec06 100644 --- a/drivers/net/dsa/microchip/ksz9477_i2c.c +++ b/drivers/net/dsa/microchip/ksz9477_i2c.c @@ -104,7 +104,7 @@ static const struct of_device_id ksz9477_dt_ids[] = { }, { .compatible = "microchip,ksz8563", - .data = &ksz_switch_chips[KSZ9893] + .data = &ksz_switch_chips[KSZ8563] }, { .compatible = "microchip,ksz9567", -- 2.30.2
| |