lkml.org 
[lkml]   [2023]   [Jan]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v6 02/34] iov_iter: Use IOCB/IOMAP_WRITE/op_is_write rather than iterator direction
On Mon, Jan 16, 2023 at 11:08:17PM +0000, David Howells wrote:
> Use information other than the iterator direction to determine the
> direction of the I/O:
>
> (*) If a kiocb is available, use the IOCB_WRITE flag.
>
> (*) If an iomap_iter is available, use the IOMAP_WRITE flag.
>
> (*) If a request is available, use op_is_write().

The really should be three independent patches. Plus another one
to drop the debug checks in cifs.

The changes themselves look good to me.

>
> +static unsigned char iov_iter_rw(const struct iov_iter *i)
> +{
> + return i->data_source ? WRITE : READ;
> +}

It might as well make sense to just open code this in the only
caller as well (yet another patch).

\
 
 \ /
  Last update: 2023-03-26 23:43    [W:0.443 / U:0.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site