Messages in this thread | | | Date | Wed, 18 Jan 2023 21:41:36 -0800 | From | Christoph Hellwig <> | Subject | Re: [PATCH v6 01/34] vfs: Unconditionally set IOCB_WRITE in call_write_iter() |
| |
On Wed, Jan 18, 2023 at 10:05:38PM +0000, Al Viro wrote: > __kernel_write_iter() is one such; for less obvious specimen see > drivers/nvme/target/io-cmd-file.c:nvmet_file_submit_bvec() - there > we have iocb coming from the caller and *not* fed to init_sync_kiocb(), > so Christoph's suggestion doesn't work either. Sure, we could take > care of that by adding ki_flags |= IOCB_WRITE in there, but...
None of the asyc users of iocbs currently uses init_sync_kiocb. My suggestion is to use it everywhere - we have less than a dozen of these that I all listed.
| |