Messages in this thread | ![/](/images/icornerl.gif) | | Date | Thu, 12 Jan 2023 15:21:14 +0100 | Subject | Re: [PATCH] arm64: dts: qcom: sc8280xp: Vote for CX in USB controllers | From | Konrad Dybcio <> |
| |
On 12.01.2023 14:51, Bjorn Andersson wrote: > Running GCC_USB30_*_MASTER_CLK at 200MHz requires CX at nominal level, > not doing so results in occasional lockups. This was previously hidden > by the fact that the display stack incorrectly voted for CX (instead of > MMCX). > > Fixes: 152d1faf1e2f ("arm64: dts: qcom: add SC8280XP platform") > Signed-off-by: Bjorn Andersson <quic_bjorande@quicinc.com> > ---https://git.codelinaro.org/clo/la/kernel/msm-5.4/-/blob/LV.AU.1.2.3.r1-03600-gen3meta.0/drivers/clk/qcom/gcc-direwolf.c#L2703-2725
Maybe in the future there could be some power savings for lower freqs..
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad > arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > index 2ed17baf50d3..4f4353f84cba 100644 > --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > @@ -2265,6 +2265,7 @@ usb_0: usb@a6f8800 { > "ss_phy_irq"; > > power-domains = <&gcc USB30_PRIM_GDSC>; > + required-opps = <&rpmhpd_opp_nom>; > > resets = <&gcc GCC_USB30_PRIM_BCR>; > > @@ -2319,6 +2320,7 @@ usb_1: usb@a8f8800 { > "ss_phy_irq"; > > power-domains = <&gcc USB30_SEC_GDSC>; > + required-opps = <&rpmhpd_opp_nom>; > > resets = <&gcc GCC_USB30_SEC_BCR>; >
| ![\](/images/icornerr.gif) |