Messages in this thread | ![/](/images/icornerl.gif) | | Date | Thu, 12 Jan 2023 10:05:47 +0100 | From | "Arnd Bergmann" <> | Subject | Re: [PATCH 2/4] ARM: pxa: remove further dead code after pxa93 support removal |
| |
On Thu, Jan 12, 2023, at 09:37, Lukas Bulwahn wrote: > Commit 150ccb6f9a89 ("ARM: pxa: remove pxa93x support") removes configs > CPU_PXA930 and CPU_PXA935 and uses of cpu_is_pxa93x() and cpu_is_pxa935(). > > Remove some further dead code in ./include/linux/soc/pxa/cpu.h on top of > that commit above. > > Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
I had this in an earlier version and ended up leaving this bit in when I reworked the series to not drop support for PXA310 and PXA320.
You are probably right that we should not reference the removed Kconfig symbols, but I see that this causes a regression unless I also bring back the change to
drivers/mmc/host/pxamci.c: || cpu_is_pxa935())
Arnd
| ![\](/images/icornerr.gif) |