Messages in this thread Patch in this message | | | From | Masami Hiramatsu <> | Subject | [PATCH] bootconfig: Free copied bootconfig data after boot | Date | Mon, 13 Sep 2021 14:41:03 +0900 |
| |
Free copied bootconfig data after booting kernel because that data will not be used anymore.
commit 40caa127f3c7 ("init: bootconfig: Remove all bootconfig data when the init memory is removed") freed the bootconfig xbc_node array after booting kernel, but forgot to free the bootconfig data itself. This fixes that to free the bootconfig data too.
This also frees the bootconfig data if the bootconfig data parsing failed.
Fixes: 40caa127f3c7 ("init: bootconfig: Remove all bootconfig data when the init memory is removed") Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org> --- init/main.c | 8 ++++++++ 1 file changed, 8 insertions(+)
diff --git a/init/main.c b/init/main.c index 5c9a48df90e1..dc433d1d5fc4 100644 --- a/init/main.c +++ b/init/main.c @@ -319,6 +319,8 @@ static void * __init get_boot_config_from_initrd(u32 *_size, u32 *_csum) #ifdef CONFIG_BOOT_CONFIG static char xbc_namebuf[XBC_KEYLEN_MAX] __initdata; +static void *init_xbc_data_copy __initdata; +static phys_addr_t init_xbc_data_size __initdata; #define rest(dst, end) ((end) > (dst) ? (end) - (dst) : 0) @@ -458,18 +460,24 @@ static void __init setup_boot_config(void) else pr_err("Failed to parse bootconfig: %s at %d.\n", msg, pos); + memblock_free(__pa(copy), size + 1); } else { pr_info("Load bootconfig: %d bytes %d nodes\n", size, ret); /* keys starting with "kernel." are passed via cmdline */ extra_command_line = xbc_make_cmdline("kernel"); /* Also, "init." keys are init arguments */ extra_init_args = xbc_make_cmdline("init"); + init_xbc_data_copy = copy; + init_xbc_data_size = size + 1; } return; } static void __init exit_boot_config(void) { + if (!init_xbc_data_copy) + return; + memblock_free(__pa(init_xbc_data_copy), init_xbc_data_size); xbc_destroy_all(); }
| |