lkml.org 
[lkml]   [2021]   [Feb]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
Subject[kbuild] drivers/scsi/ufs/ufs-mediatek.c:530:17: sparse: sparse: dubious: x & !y
tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git  master
head: 29c395c77a9a514c5857c45ceae2665e9bd99ac7
commit: 488edafb1120f715bebd80b6fe4089f83fb082b2 scsi: ufs-mediatek: Introduce low-power mode for device power supply
config: arm64-randconfig-s031-20210225 (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.3.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# apt-get install sparse
# sparse version: v0.6.3-229-g60c1f270-dirty
# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=488edafb1120f715bebd80b6fe4089f83fb082b2
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git fetch --no-tags linus master
git checkout 488edafb1120f715bebd80b6fe4089f83fb082b2
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=arm64

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

"sparse warnings: (new ones prefixed by >>)"
drivers/scsi/ufs/ufs-mediatek.c:182:5: sparse: sparse: symbol 'ufs_mtk_wait_link_state' was not declared. Should it be static?
>> drivers/scsi/ufs/ufs-mediatek.c:530:17: sparse: sparse: dubious: x & !y

vim +530 drivers/scsi/ufs/ufs-mediatek.c

488edafb1120f7 Stanley Chu 2020-06-01 525 static void ufs_mtk_vreg_set_lpm(struct ufs_hba *hba, bool lpm)
488edafb1120f7 Stanley Chu 2020-06-01 526 {
488edafb1120f7 Stanley Chu 2020-06-01 527 if (!hba->vreg_info.vccq2)
488edafb1120f7 Stanley Chu 2020-06-01 528 return;
488edafb1120f7 Stanley Chu 2020-06-01 529
488edafb1120f7 Stanley Chu 2020-06-01 @530 if (lpm & !hba->vreg_info.vcc->enabled)

This works because both sides are bool, but why not just use &&?

488edafb1120f7 Stanley Chu 2020-06-01 531 regulator_set_mode(hba->vreg_info.vccq2->reg,
488edafb1120f7 Stanley Chu 2020-06-01 532 REGULATOR_MODE_IDLE);
488edafb1120f7 Stanley Chu 2020-06-01 533 else if (!lpm)
488edafb1120f7 Stanley Chu 2020-06-01 534 regulator_set_mode(hba->vreg_info.vccq2->reg,
488edafb1120f7 Stanley Chu 2020-06-01 535 REGULATOR_MODE_NORMAL);
488edafb1120f7 Stanley Chu 2020-06-01 536 }

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[unhandled content-type:application/gzip]_______________________________________________
kbuild mailing list -- kbuild@lists.01.org
To unsubscribe send an email to kbuild-leave@lists.01.org
\
 
 \ /
  Last update: 2021-02-25 16:37    [W:0.023 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site