lkml.org 
[lkml]   [2021]   [Dec]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] [kexec]: arch/arm64/kernel/machine_kexec_file.c:152 load_other_segments() warn: missing error code 'ret'
    Date
    Return code is not set to an error code in load_other_segments() when
    of_kexec_alloc_and_setup_fdt() call returns a NULL dtb. This results
    in status success (return code set to 0) being returned from
    load_other_segments().

    Set return code to -ENOMEM if of_kexec_alloc_and_setup_fdt() returns
    NULL dtb.

    Signed-off-by: Lakshmi Ramasubramanian <nramas@linux.microsoft.com>
    Reported-by: kernel test robot <lkp@intel.com>
    Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
    ---
    Patch created in dt/next branch in git repo
    https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git

    arch/arm64/kernel/machine_kexec_file.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/arch/arm64/kernel/machine_kexec_file.c b/arch/arm64/kernel/machine_kexec_file.c
    index 63634b4d72c1..04d072885e64 100644
    --- a/arch/arm64/kernel/machine_kexec_file.c
    +++ b/arch/arm64/kernel/machine_kexec_file.c
    @@ -149,6 +149,7 @@ int load_other_segments(struct kimage *image,
    initrd_len, cmdline, 0);
    if (!dtb) {
    pr_err("Preparing for new dtb failed\n");
    + ret = -ENOMEM;
    goto out_err;
    }

    --
    2.25.1
    \
     
     \ /
      Last update: 2021-12-08 18:09    [W:5.219 / U:0.140 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site