Messages in this thread Patch in this message | | | From | Arnd Bergmann <> | Subject | [PATCH] power: reset: ltc2952: fix float conversion error | Date | Sat, 4 Dec 2021 23:01:49 +0100 |
| |
From: Arnd Bergmann <arnd@arndb.de>
clang-14 does not like the way this driver converts a 'long double' to an integer when the target architecture disables floating point support:
drivers/power/reset/ltc2952-poweroff.c:162:28: error: expression requires 'long double' type support, but target 'x86_64-unknown-linux' does not support it data->wde_interval = 300L * 1E6L; ^
Turn this into pure integer math and make it more readable at the same time using the NSEC_PER_MSEC macro instead.
Fixes: 6647156c00cc ("power: reset: add LTC2952 poweroff driver") Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/power/reset/ltc2952-poweroff.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/power/reset/ltc2952-poweroff.c b/drivers/power/reset/ltc2952-poweroff.c index fbb344353fe4..9fc88a9f244c 100644 --- a/drivers/power/reset/ltc2952-poweroff.c +++ b/drivers/power/reset/ltc2952-poweroff.c @@ -159,8 +159,8 @@ static void ltc2952_poweroff_kill(void) static void ltc2952_poweroff_default(struct ltc2952_poweroff *data) { - data->wde_interval = 300L * 1E6L; - data->trigger_delay = ktime_set(2, 500L*1E6L); + data->wde_interval = 300 * NSEC_PER_MSEC; + data->trigger_delay = ktime_set(2, 500 * NSEC_PER_MSEC); hrtimer_init(&data->timer_trigger, CLOCK_MONOTONIC, HRTIMER_MODE_REL); data->timer_trigger.function = ltc2952_poweroff_timer_trigger; -- 2.29.2
| |