Messages in this thread | | | From | Lukas Bulwahn <> | Date | Thu, 30 Dec 2021 13:45:08 +0100 | Subject | Reference to non-existing config LOGIC_IOMEM_FALLBACK |
| |
Dear Johannes, dear Richard,
In commit ca2e334232b6 ("lib: add iomem emulation (logic_iomem)"), you have added an ifdef on the non-existing config LOGIC_IOMEM_FALLBACK in ./lib/logic_iomem.c.
In the commit message, you note:
To use, an architecture must 'select LOGIC_IOMEM' in Kconfig and then include <asm-generic/logic_io.h> into asm/io.h to get the __raw_read*/__raw_write* functions.
Optionally, an architecture may 'select LOGIC_IOMEM_FALLBACK' in which case non-emulated regions will 'fall back' to the various real_* functions that must then be provided.
This config LOGIC_IOMEM and config LOGIC_IOMEM_FALLBACK is however not defined in any Kconfig file in the current repository.
Did you mean that the architecture shall select INDIRECT_IOMEM and INDIRECT_IOMEM_FALLBACK, which were defined in your commit, and the questionable ifdef in ./lib/logic_iomem.c needs to be changed to INDIRECT_IOMEM_FALLBACK? Or, are we simply missing the definitions for the config LOGIC_IOMEM and LOGIC_IOMEM_FALLBACK?
This issue was identified with the script ./scripts/checkkconfigsymbols.py.
Best regards,
Lukas
| |