Messages in this thread Patch in this message | | | From | Aleksander Jan Bajkowski <> | Subject | [PATCH net-next] net: lantiq_etop: add missing comment for wmb() | Date | Tue, 28 Dec 2021 22:49:10 +0100 |
| |
This patch adds the missing code comment for memory barrier call and fixes checkpatch warning:
WARNING: memory barrier without comment + wmb();
Signed-off-by: Aleksander Jan Bajkowski <olek2@wp.pl> --- drivers/net/ethernet/lantiq_etop.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/lantiq_etop.c b/drivers/net/ethernet/lantiq_etop.c index 072391c494ce..5d90cc147950 100644 --- a/drivers/net/ethernet/lantiq_etop.c +++ b/drivers/net/ethernet/lantiq_etop.c @@ -498,6 +498,7 @@ ltq_etop_tx(struct sk_buff *skb, struct net_device *dev) spin_lock_irqsave(&priv->lock, flags); desc->addr = ((unsigned int) dma_map_single(&priv->pdev->dev, skb->data, len, DMA_TO_DEVICE)) - byte_offset; + /* Make sure the address is written before we give it to HW */ wmb(); desc->ctl = LTQ_DMA_OWN | LTQ_DMA_SOP | LTQ_DMA_EOP | LTQ_DMA_TX_OFFSET(byte_offset) | (len & LTQ_DMA_SIZE_MASK); -- 2.30.2
| |