Messages in this thread Patch in this message | | | From | Miaoqian Lin <> | Subject | [PATCH] remoteproc: Fix NULL vs IS_ERR() checking in rproc_create_trace_file | Date | Mon, 27 Dec 2021 09:06:45 +0000 |
| |
The debugfs_create_file() function doesn't return NULL. It returns error pointers.
Signed-off-by: Miaoqian Lin <linmq006@gmail.com> --- drivers/remoteproc/remoteproc_debugfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/remoteproc/remoteproc_debugfs.c b/drivers/remoteproc/remoteproc_debugfs.c index b5a1e3b697d9..a2409fe2f57b 100644 --- a/drivers/remoteproc/remoteproc_debugfs.c +++ b/drivers/remoteproc/remoteproc_debugfs.c @@ -390,7 +390,7 @@ struct dentry *rproc_create_trace_file(const char *name, struct rproc *rproc, tfile = debugfs_create_file(name, 0400, rproc->dbg_dir, trace, &trace_rproc_ops); - if (!tfile) { + if (IS_ERR(tfile)) { dev_err(&rproc->dev, "failed to create debugfs trace entry\n"); return NULL; } -- 2.17.1
| |