Messages in this thread | ![/](/images/icornerl.gif) | | From | Clark Wang <> | Subject | [PATCH V5 0/8] i3c: master: svc: some bug fixes and add runtime pm support | Date | Mon, 27 Dec 2021 15:45:21 +0800 |
| |
Hi Miquel,
Currently, only the fourth patch needs to be reviewed, and the rest have been added with your review tag.
Thank you very much for your comments! :)
V5 changes: - i3c: master: svc: add support for slave to stop returning data - remove <%s> in logs - add some spaces - !SVC_I3C_MSTATUS_STATE(reg) -> SVC_I3C_MSTATUS_STATE_IDLE(reg) - i3c: master: svc: add runtime pm support - create svc_i3c_master_prepare_clks() and svc_i3c_master_unprepare_clks()
V4 changes: - New patches: - i3c: master: svc: separate err, fifo and disable interrupt of reset function - i3c: master: svc: add the missing module device table - i3c: master: svc: enable the interrupt in the enable ibi function - i3c: master: svc: add support for slave to stop returning data - Only use COMPLETE flag in the read function. - Add a reset before each transfer. - i3c: master: svc: add runtime pm support - error path emit_stop only used in svc_i3c_master_do_daa() for one time, so remove it. Or it needs another goto command at the end of the function to skip it and to go to rpm_out.
V3 changes: - i3c: master: svc: add runtime pm support: - restore the error path of probe function - enable runtime pm just before i3c module reset
V2 changes: - align the parameters of the function in the second patch - add a new patch to support runtime PM.
Clark Wang (8): i3c: master: svc: move module reset behind clk enable i3c: master: svc: fix atomic issue i3c: master: svc: separate err, fifo and disable interrupt of reset function i3c: master: svc: add support for slave to stop returning data i3c: master: svc: set ODSTOP to let I2C device see the STOP signal i3c: master: svc: add runtime pm support i3c: master: svc: add the missing module device table i3c: master: svc: enable the interrupt in the enable ibi function
drivers/i3c/master/svc-i3c-master.c | 341 ++++++++++++++++++++-------- 1 file changed, 250 insertions(+), 91 deletions(-)
-- 2.25.1
| ![\](/images/icornerr.gif) |