Messages in this thread Patch in this message | | | From | Jiasheng Jiang <> | Subject | [PATCH v5] fjes: Check for error irq | Date | Fri, 24 Dec 2021 09:34:45 +0800 |
| |
The platform_get_irq() is possible to fail. And the returned irq could be error number and will finally cause the failure of the request_irq(). Consider that platform_get_irq() can now in certain cases return -EPROBE_DEFER, and the consequences of letting request_irq() effectively convert that into -EINVAL, even at probe time rather than later on. So it might be better to check just now.
Fixes: 658d439b2292 ("fjes: Introduce FUJITSU Extended Socket Network Device driver") Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn> --- Changelog:
v4 -> v5
*Change 1. Using error variable to check. *Change 2. Correct the word. *Change 3. Add new commit message. *Change 4. Refine the commit message to be more reasonable. --- drivers/net/fjes/fjes_main.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/net/fjes/fjes_main.c b/drivers/net/fjes/fjes_main.c index e449d9466122..17f2fd937e4d 100644 --- a/drivers/net/fjes/fjes_main.c +++ b/drivers/net/fjes/fjes_main.c @@ -1268,7 +1268,12 @@ static int fjes_probe(struct platform_device *plat_dev) } hw->hw_res.start = res->start; hw->hw_res.size = resource_size(res); - hw->hw_res.irq = platform_get_irq(plat_dev, 0); + + err = platform_get_irq(plat_dev, 0); + if (err < 0) + goto err_free_control_wq; + hw->hw_res.irq = err; + err = fjes_hw_init(&adapter->hw); if (err) goto err_free_control_wq; -- 2.25.1
| |