Messages in this thread Patch in this message | | | From | Qing Wang <> | Subject | [PATCH] soc: dove: add missing of_node_put before break | Date | Mon, 13 Dec 2021 01:46:09 -0800 |
| |
From: Wang Qing <wangqing@vivo.com>
Fix following coccicheck warning: WARNING: Function "for_each_available_child_of_node" should have of_node_put() before return.
Early exits from for_each_available_child_of_node should decrement the node reference counter.
Signed-off-by: Wang Qing <wangqing@vivo.com> --- drivers/soc/dove/pmu.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/soc/dove/pmu.c b/drivers/soc/dove/pmu.c index ffc5311..6202dbc --- a/drivers/soc/dove/pmu.c +++ b/drivers/soc/dove/pmu.c @@ -410,13 +410,16 @@ int __init dove_init_pmu(void) struct pmu_domain *domain; domain = kzalloc(sizeof(*domain), GFP_KERNEL); - if (!domain) + if (!domain) { + of_node_put(np); break; + } domain->pmu = pmu; domain->base.name = kasprintf(GFP_KERNEL, "%pOFn", np); if (!domain->base.name) { kfree(domain); + of_node_put(np); break; } -- 2.7.4
| |