Messages in this thread Patch in this message | | | From | Qing Wang <> | Subject | [PATCH] mailbox: mtk: add missing of_node_put before return | Date | Mon, 13 Dec 2021 01:44:05 -0800 |
| |
From: Wang Qing <wangqing@vivo.com>
Fix following coccicheck warning: WARNING: Function "for_each_child_of_node" should have of_node_put() before return.
Early exits from for_each_child_of_node should decrement the node reference counter.
Signed-off-by: Wang Qing <wangqing@vivo.com> --- drivers/mailbox/mtk-cmdq-mailbox.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c b/drivers/mailbox/mtk-cmdq-mailbox.c index a8845b1..03abad5 --- a/drivers/mailbox/mtk-cmdq-mailbox.c +++ b/drivers/mailbox/mtk-cmdq-mailbox.c @@ -573,6 +573,7 @@ static int cmdq_probe(struct platform_device *pdev) cmdq->clocks[alias_id].id = clk_names[alias_id]; cmdq->clocks[alias_id].clk = of_clk_get(node, 0); if (IS_ERR(cmdq->clocks[alias_id].clk)) { + of_node_put(node); dev_err(dev, "failed to get gce clk: %d\n", alias_id); return PTR_ERR(cmdq->clocks[alias_id].clk); } -- 2.7.4
| |