Messages in this thread Patch in this message | | | From | Zhen Lei <> | Subject | [PATCH] smp: Fix the comments of smp_call_function_many() | Date | Mon, 13 Dec 2021 11:57:55 +0800 |
| |
As commit a32a4d8a815c ("smp: Run functions concurrently in smp_call_function_many_cond()") itself says: "Keep other smp_call_function_many() semantic as it is today for backward compatibility: the called function is not executed in this case locally."
It's clear that, the function header comments of smp_call_function_many() does not need to be changed.
So move the comment about 'scf_flags' to smp_call_function_many_cond(), and restore the original comments of smp_call_function_many().
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com> --- kernel/smp.c | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-)
diff --git a/kernel/smp.c b/kernel/smp.c index 01a7c1706a58b1d..6ec884f41b7506d 100644 --- a/kernel/smp.c +++ b/kernel/smp.c @@ -861,6 +861,13 @@ EXPORT_SYMBOL_GPL(smp_call_function_any); #define SCF_WAIT (1U << 0) #define SCF_RUN_LOCAL (1U << 1) +/** + * smp_call_function_many_cond(): Run a function on a set of CPUs. + * @scf_flags: Bitmask that controls the operation. If %SCF_WAIT is set, + * wait (atomically) until function has completed on other CPUs. If + * %SCF_RUN_LOCAL is set, the function will also be run locally + * if the local CPU is set in the @cpumask. + */ static void smp_call_function_many_cond(const struct cpumask *mask, smp_call_func_t func, void *info, unsigned int scf_flags, @@ -972,14 +979,12 @@ static void smp_call_function_many_cond(const struct cpumask *mask, } /** - * smp_call_function_many(): Run a function on a set of CPUs. + * smp_call_function_many(): Run a function on a set of other CPUs. * @mask: The set of cpus to run on (only runs on online subset). * @func: The function to run. This must be fast and non-blocking. * @info: An arbitrary pointer to pass to the function. - * @wait: Bitmask that controls the operation. If %SCF_WAIT is set, wait - * (atomically) until function has completed on other CPUs. If - * %SCF_RUN_LOCAL is set, the function will also be run locally - * if the local CPU is set in the @cpumask. + * @wait: If true, wait (atomically) until function has completed + * on other CPUs. * * If @wait is true, then returns once @func has returned. * -- 2.25.1
| |