Messages in this thread Patch in this message | | | From | Andy Shevchenko <> | Subject | [PATCH v1] kobject: Drop unneeded conditional in __kobject_del() | Date | Mon, 3 Aug 2020 11:35:20 +0300 |
| |
__kobject_del() is called from two places, in one where kobj is dereferenced before and thus can't be NULL, and in the other the NULL check is done before call. Drop unneeded conditional in __kobject_del().
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> ---
It is possible after refactoring kobject_del(). Though I decided to do it in a separate change (no need to backport) for better test coverage.
lib/kobject.c | 3 --- 1 file changed, 3 deletions(-)
diff --git a/lib/kobject.c b/lib/kobject.c index 9dce68c378e6..ea53b30cf483 100644 --- a/lib/kobject.c +++ b/lib/kobject.c @@ -604,9 +604,6 @@ static void __kobject_del(struct kobject *kobj) struct kernfs_node *sd; const struct kobj_type *ktype; - if (!kobj) - return; - sd = kobj->sd; ktype = get_ktype(kobj); -- 2.27.0
| |