Messages in this thread | | | Date | Fri, 21 Aug 2020 06:46:53 +0100 | From | Christoph Hellwig <> | Subject | Re: [PATCH v5 6/8] mm: Move vmap_range from lib/ioremap.c to mm/vmalloc.c |
| |
On Fri, Aug 21, 2020 at 02:44:25PM +1000, Nicholas Piggin wrote: > This is a generic kernel virtual memory mapper, not specific to ioremap.
lib/ioremap doesn't exist any more.
> > Signed-off-by: Nicholas Piggin <npiggin@gmail.com> > --- > include/linux/vmalloc.h | 2 + > mm/ioremap.c | 192 ---------------------------------------- > mm/vmalloc.c | 191 +++++++++++++++++++++++++++++++++++++++ > 3 files changed, 193 insertions(+), 192 deletions(-) > > diff --git a/include/linux/vmalloc.h b/include/linux/vmalloc.h > index 787d77ad7536..e3590e93bfff 100644 > --- a/include/linux/vmalloc.h > +++ b/include/linux/vmalloc.h > @@ -181,6 +181,8 @@ extern struct vm_struct *remove_vm_area(const void *addr); > extern struct vm_struct *find_vm_area(const void *addr); > > #ifdef CONFIG_MMU > +extern int vmap_range(unsigned long addr, unsigned long end, phys_addr_t phys_addr, pgprot_t prot, > + unsigned int max_page_shift);
Please avoid the pointlessly long line. And don't add the pointless extern.
| |