Messages in this thread | | | Date | Fri, 21 Aug 2020 06:45:08 +0100 | From | Christoph Hellwig <> | Subject | Re: [PATCH v5 3/8] mm/vmalloc: rename vmap_*_range vmap_pages_*_range |
| |
On Fri, Aug 21, 2020 at 02:44:22PM +1000, Nicholas Piggin wrote: > The vmalloc mapper operates on a struct page * array rather than a > linear physical address, re-name it to make this distinction clear. > > Signed-off-by: Nicholas Piggin <npiggin@gmail.com> > --- > mm/vmalloc.c | 28 ++++++++++++---------------- > 1 file changed, 12 insertions(+), 16 deletions(-) > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index 49f225b0f855..3a1e45fd1626 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -190,9 +190,8 @@ void unmap_kernel_range_noflush(unsigned long start, unsigned long size) > arch_sync_kernel_mappings(start, end); > } > > -static int vmap_pte_range(pmd_t *pmd, unsigned long addr, > - unsigned long end, pgprot_t prot, struct page **pages, int *nr, > - pgtbl_mod_mask *mask) > +static int vmap_pages_pte_range(pmd_t *pmd, unsigned long addr, unsigned long end, > + pgprot_t prot, struct page **pages, int *nr, pgtbl_mod_mask *mask)
Please don't add > 80 lines without any good reason.
| |