lkml.org 
[lkml]   [2020]   [Aug]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] staging: emxx_udc: Use standard BIT() macro
On Tue, Aug 18, 2020 at 07:29:02AM -0700, Randy Dunlap wrote:
> On 8/18/20 6:49 AM, Alex Dewar wrote:
> > Currently emxx_udc.h defines bit values using local macros. Use the
> > standard one instead.
> >
> > Also, combine bit values with bitwise-or rather than addition, as
> > suggested by Coccinelle.
> >
> > Signed-off-by: Alex Dewar <alex.dewar90@gmail.com>
>
> Hi,
>
> Does this build? Just checking.
>
> Looks like it would need this:
>
> #include <linux/bits.h>
>
> since it (indirectly) provides definition of the BIT() macro.

Yeah, it builds, because emxx_udc.c includes emxx_udc.h after a bunch of
standard headers. I agree that it would probably be cleaner to have the
include in there explicitly, though.

Best,
Alex

>
> > ---
> > drivers/staging/emxx_udc/emxx_udc.h | 456 +++++++++++++---------------
> > 1 file changed, 211 insertions(+), 245 deletions(-)
>
>
> thanks.
> --
> ~Randy
>

\
 
 \ /
  Last update: 2020-08-18 17:07    [W:0.030 / U:0.652 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site