lkml.org 
[lkml]   [2020]   [Aug]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] staging: emxx_udc: Use standard BIT() macro
From
Date
On 8/18/20 6:49 AM, Alex Dewar wrote:
> Currently emxx_udc.h defines bit values using local macros. Use the
> standard one instead.
>
> Also, combine bit values with bitwise-or rather than addition, as
> suggested by Coccinelle.
>
> Signed-off-by: Alex Dewar <alex.dewar90@gmail.com>

Hi,

Does this build? Just checking.

Looks like it would need this:

#include <linux/bits.h>

since it (indirectly) provides definition of the BIT() macro.

> ---
> drivers/staging/emxx_udc/emxx_udc.h | 456 +++++++++++++---------------
> 1 file changed, 211 insertions(+), 245 deletions(-)


thanks.
--
~Randy

\
 
 \ /
  Last update: 2020-08-18 16:29    [W:0.048 / U:0.672 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site