Messages in this thread | | | Date | Tue, 18 Aug 2020 13:19:54 +0200 | From | Greg KH <> | Subject | Re: [PATCH v2] Fixes: tty: serial: earlycon dependency |
| |
On Mon, Aug 17, 2020 at 02:54:19PM -0400, Tong Zhang wrote: > parse_options() in drivers/tty/serial/earlycon.c calls uart_parse_earlycon > in drivers/tty/serial/serial_core.c therefore selecting SERIAL_EARLYCON > should automatically select SERIAL_CORE, otherwise will result in symbol > not found error during linking if SERIAL_CORE is not configured as builtin > > Signed-off-by: Tong Zhang <ztong0001@gmail.com>
As Jiri pointed out, the Fixes: line goes down here, not in your subject line :)
Please fix up, thanks.
> --- > drivers/tty/serial/Kconfig | 1 + > 1 file changed, 1 insertion(+)
What changed from v1? Also always list that below the --- line so we know.
thanks,
greg k-h
| |