lkml.org 
[lkml]   [2020]   [Aug]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v2] Fixes: tty: serial: earlycon dependency
    From
    Date
    On 17. 08. 20, 20:54, Tong Zhang wrote:
    > parse_options() in drivers/tty/serial/earlycon.c calls uart_parse_earlycon
    > in drivers/tty/serial/serial_core.c therefore selecting SERIAL_EARLYCON
    > should automatically select SERIAL_CORE, otherwise will result in symbol
    > not found error during linking if SERIAL_CORE is not configured as builtin
    >
    > Signed-off-by: Tong Zhang <ztong0001@gmail.com>

    The "Fixes:" keyword should not have been in the Subject but here.
    According to your findings something like this:

    Fixes: 73abaf87f01b (serial: earlycon: Refactor parse_options into
    serial core)

    I am not sure:
    1) it should be "select" (and not "depends")
    2) serial earlycon should depend on serial core. But it's likely OK.

    > drivers/tty/serial/Kconfig | 1 +
    > 1 file changed, 1 insertion(+)
    >
    > diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
    > index 8a0352eb337c..42e844314cbb 100644
    > --- a/drivers/tty/serial/Kconfig
    > +++ b/drivers/tty/serial/Kconfig
    > @@ -8,6 +8,7 @@ menu "Serial drivers"
    >
    > config SERIAL_EARLYCON
    > bool
    > + select SERIAL_CORE
    > help
    > Support for early consoles with the earlycon parameter. This enables
    > the console before standard serial driver is probed. The console is
    >

    thanks,
    --
    js
    suse labs

    \
     
     \ /
      Last update: 2020-08-18 07:42    [W:5.979 / U:0.480 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site