lkml.org 
[lkml]   [2020]   [Aug]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] bpf: Convert to use the preferred fallthrough macro
Date
Andrii Nakryiko <andrii.nakryiko@gmail.com> wrote:
On Fri, Aug 14, 2020 at 2:58 AM Miaohe Lin <linmiaohe@huawei.com> wrote:
>>
>> Convert the uses of fallthrough comments to fallthrough macro.
>> @@ -1794,7 +1794,7 @@ static bool cg_sockopt_is_valid_access(int off, int size,
>> return prog->expected_attach_type ==
>> BPF_CGROUP_GETSOCKOPT;
>> case offsetof(struct bpf_sockopt, optname):
>> - /* fallthrough */
>> + fallthrough;
>
>this fallthrough is not event necessary, let's drop it instead?

Will do. Many thanks.

>
>> case offsetof(struct bpf_sockopt, level):
>> if (size != size_default)
>> return false;
>
> [...]
\
 
 \ /
  Last update: 2020-08-16 03:50    [W:0.272 / U:0.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site