Messages in this thread | | | Subject | Re: [PATCH 2/2] Crypto/chcr: Fix some pr_xxx messages | From | Markus Elfring <> | Date | Mon, 13 Jul 2020 22:00:30 +0200 |
| |
… > +++ b/drivers/crypto/chelsio/chcr_algo.c > @@ -1224,7 +1224,7 @@ static int chcr_handle_cipher_resp(struct skcipher_request *req, > wrparam.bytes = bytes; > skb = create_cipher_wr(&wrparam); > if (IS_ERR(skb)) { > - pr_err("chcr : %s : Failed to form WR. No memory\n", __func__); > + pr_err("%s : Failed to form WR. No memory\n", __func__); > err = PTR_ERR(skb); > goto unmap; > }
I suggest to omit also a space character before the colon in such format strings.
+ pr_err("%s: Failed to form WR. No memory\n", __func__);
Would you like to apply any further fine-tuning around affected error messages?
Regards, Markus
| |