Messages in this thread | | | Subject | Re: [PATCH] fbdev: geocode: Add the missed pci_disable_device() in gx1fb_map_video_memory() | From | Markus Elfring <> | Date | Wed, 3 Jun 2020 18:48:31 +0200 |
| |
> Add the missed function call to fix the bug.
… > +++ b/drivers/video/fbdev/geode/gx1fb_core.c > @@ -208,29 +208,44 @@ static int gx1fb_map_video_memory(struct fb_info *info, struct pci_dev *dev) … > return 0; > + > +err: > + pci_disable_device(dev); > + return ret; > } …
I suggest to use more descriptive labels so that the exception handling can be improved accordingly.
return 0; + +e_nomem: + ret = -ENOMEM; +disable_device: + pci_disable_device(dev); + return ret; }
Regards, Markus
| |