lkml.org 
[lkml]   [2020]   [Jun]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] coccinelle: misc: add array_size_dup script to detect missed overflow checks
From
Date
I suggest to avoid a typo in the previous patch subject.



> +virtual context
> +virtual report
> +virtual org

+virtual context, report, org

Is such a SmPL code variant more succinct?



> +@as_next@
> +expression subE1 <= as.E1;
> +expression as.E1;


I propose to reduce the repetition of this SmPL key word.



> + ... when != \(E1\|E2\|subE1\|subE2\)=E3
> + when != \(E1\|E2\|subE1\|subE2\)+=E3


Can it make sense to express a constraint for a metavariable of
the type “assignment operator”?


> + when != \(&E1\|&E2\|&subE1\|&subE2\)

How do you think about to use the following code exclusion specification?

+ when != & \(E1 \| E2 \| subE1 \| subE2\)



> +msg = "WARNING: same struct_size (line %s)" % (p1[0].line)
> +coccilib.org.print_todo(p2[0], msg)

I suggest once more to pass the desired message object directly as a function argument
(without using an extra Python variable).

Regards,
Markus

\
 
 \ /
  Last update: 2020-06-15 14:26    [W:0.025 / U:0.752 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site