Messages in this thread | | | From | Markus Elfring <> | Subject | Input: ep93xx_keypad: Checking for a failed platform_get_irq() call in ep93xx_keypad_probe() | Date | Wed, 8 Apr 2020 18:52:31 +0200 |
| |
Hello,
I have taken another look at the implementation of the function “ep93xx_keypad_probe”. A software analysis approach points the following source code out for further development considerations. https://elixir.bootlin.com/linux/v5.6.3/source/drivers/input/keyboard/ep93xx_keypad.c#L252 https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/input/keyboard/ep93xx_keypad.c?id=f5e94d10e4c468357019e5c28d48499f677b284f#n252
keypad->irq = platform_get_irq(pdev, 0); if (!keypad->irq) { err = -ENXIO; goto failed_free; }
The software documentation is providing the following information for the used programming interface. https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/base/platform.c?id=f5e94d10e4c468357019e5c28d48499f677b284f#n221 https://elixir.bootlin.com/linux/v5.6.3/source/drivers/base/platform.c#L202
“… * Return: IRQ number on success, negative error number on failure. …”
Would you like to reconsider the shown condition check?
Regards, Markus
| |