Messages in this thread Patch in this message | | | From | Bernard Zhao <> | Subject | [PATCH] drm/amd: remove unnecessary conversion from bool value to bool | Date | Wed, 14 Oct 2020 19:42:30 -0700 |
| |
In functions vegam_is_dpm_running & vegam_populate_avfs_parameters, maybe there is no need to conver bool condition to bool variable or bool return value. This change is to make the code a bit more readable.
Signed-off-by: Bernard Zhao <bernard@vivo.com> --- drivers/gpu/drm/amd/powerplay/smumgr/vegam_smumgr.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/amd/powerplay/smumgr/vegam_smumgr.c b/drivers/gpu/drm/amd/powerplay/smumgr/vegam_smumgr.c index 0ecc18b55ffb..32ca472f58a6 100644 --- a/drivers/gpu/drm/amd/powerplay/smumgr/vegam_smumgr.c +++ b/drivers/gpu/drm/amd/powerplay/smumgr/vegam_smumgr.c @@ -296,8 +296,9 @@ static int vegam_process_firmware_header(struct pp_hwmgr *hwmgr) static bool vegam_is_dpm_running(struct pp_hwmgr *hwmgr) { return (1 == PHM_READ_INDIRECT_FIELD(hwmgr->device, - CGS_IND_REG__SMC, FEATURE_STATUS, VOLTAGE_CONTROLLER_ON)) - ? true : false; + CGS_IND_REG__SMC, + FEATURE_STATUS, + VOLTAGE_CONTROLLER_ON)); } static uint32_t vegam_get_mac_definition(uint32_t value) @@ -1661,7 +1662,7 @@ static int vegam_populate_avfs_parameters(struct pp_hwmgr *hwmgr) (avfs_params.ucEnableGB_FUSE_TABLE_CKSON << AVFSGB0_Vdroop_Enable_SHIFT) | (avfs_params.ucEnableGB_FUSE_TABLE_CKSOFF << AVFSGB1_Vdroop_Enable_SHIFT); data->apply_avfs_cks_off_voltage = - (avfs_params.ucEnableApplyAVFS_CKS_OFF_Voltage == 1) ? true : false; + (avfs_params.ucEnableApplyAVFS_CKS_OFF_Voltage == 1); } return result; } -- 2.28.0
| |