Messages in this thread Patch in this message | | | From | Guido Günther <> | Subject | [PATCH 2/5] leds: lm3692x: Don't overwrite return value in error path | Date | Tue, 17 Sep 2019 19:19:55 -0700 |
| |
The driver currently reports successful initialization on every failure as long as it's able to power off the regulator. Don't check the return value of regulator_disable to avoid that.
Signed-off-by: Guido Günther <agx@sigxcpu.org> --- drivers/leds/leds-lm3692x.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/leds/leds-lm3692x.c b/drivers/leds/leds-lm3692x.c index 487228c2bed2..f394669ad8f2 100644 --- a/drivers/leds/leds-lm3692x.c +++ b/drivers/leds/leds-lm3692x.c @@ -312,15 +312,12 @@ static int lm3692x_init(struct lm3692x_led *led) if (led->enable_gpio) gpiod_direction_output(led->enable_gpio, 0); - if (led->regulator) { - ret = regulator_disable(led->regulator); - if (ret) - dev_err(&led->client->dev, - "Failed to disable regulator\n"); - } + if (led->regulator) + regulator_disable(led->regulator); return ret; } + static int lm3692x_probe_dt(struct lm3692x_led *led) { struct fwnode_handle *child = NULL; -- 2.23.0.rc1
| |