Messages in this thread Patch in this message | | | From | Brendan Jackman <> | Subject | [PATCH v2] checkpatch: exclude sizeof sub-expressions from MACRO_ARG_REUSE | Date | Tue, 6 Aug 2019 07:09:06 +0000 |
| |
The arguments of sizeof are not evaluated so arguments are safe to re-use in that context. Excluding sizeof sub-expressions means macros like ARRAY_SIZE can pass checkpatch.
Cc: Andy Whitcroft <apw@canonical.com> Cc: Joe Perches <joe@perches.com> Signed-off-by: Brendan Jackman <brendan.jackman@bluwireless.co.uk> --- v2 is the same patch, I just forgot to add CCs to the original. --- scripts/checkpatch.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 93a7edfe0f05..907a8e8d80ae 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -5191,7 +5191,7 @@ sub process { next if ($arg =~ /\.\.\./); next if ($arg =~ /^type$/i); my $tmp_stmt = $define_stmt; - $tmp_stmt =~ s/\b(typeof|__typeof__|__builtin\w+|typecheck\s*\(\s*$Type\s*,|\#+)\s*\(*\s*$arg\s*\)*\b//g; + $tmp_stmt =~ s/\b(sizeof|typeof|__typeof__|__builtin\w+|typecheck\s*\(\s*$Type\s*,|\#+)\s*\(*\s*$arg\s*\)*\b//g; $tmp_stmt =~ s/\#+\s*$arg\b//g; $tmp_stmt =~ s/\b$arg\s*\#\#//g; my $use_cnt = () = $tmp_stmt =~ /\b$arg\b/g; -- 2.17.1
| |