Messages in this thread | | | From | Kevin Hilman <> | Subject | Re: [PATCH 6/6] arm64: dts: add support for SM1 based SEI Robotics SEI610 | Date | Tue, 20 Aug 2019 13:32:40 -0700 |
| |
Martin Blumenstingl <martin.blumenstingl@googlemail.com> writes:
> Hi Neil, > > On Tue, Aug 20, 2019 at 4:43 PM Neil Armstrong <narmstrong@baylibre.com> wrote: >> >> Add support for the Amlogic SM1 Based SEI610 board. >> >> The SM1 SoC is a derivative of the G12A SoC Family with : >> - Cortex-A55 core instead of A53 >> - more power domains, including USB & PCIe >> - a neural network co-processor (NNA) >> - a CSI input and image processor >> - some changes in the audio complex, thus not yet enabled >> >> The SEI610 board is a derivative of the SEI510 board with : >> - removed ADC based touch button, replaced with 3x GPIO buttons >> - physical switch disabling on-board MICs >> - USB-C port for USB 2.0 OTG >> - On-board FTDI USB2SERIAL port for Linux console >> >> Audio, Display and USB support will be added later when support of the >> corresponding power domains will be added, for now they are kept disabled. >> >> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> > I don't have any details about this board but overall this looks sane, so: > Acked-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> > > [...] >> + /* Used by Tuner, RGB Led & IR Emitter LED array */ >> + vddao_3v3_t: regultor-vddao_3v3_t { > that should be regulator-vddao_3v3_t - maybe Kevin can fix this up, if > not then we can still fix it with a follow-up patch
I fixed it up while applying,
Kevin
| |