Messages in this thread | | | Date | Fri, 2 Aug 2019 23:37:56 +0200 | From | Christoph Hellwig <> | Subject | please revert "drm/msm: Use the correct dma_sync calls in msm_gem" |
| |
Hi Rob,
I just saw your above commit in Linus' tree, which is completely bogus and misunderstand the DMA API. Next time you have any issues please Cc the relevant maintainers and mailing lists. But even more importantly get_dma_ops is an completely internal API, and whatevet your helpers are trying to do is bad - if the dma wasn't mapped at the time you call the new sync_for_device helper, this is broken because you can't call dma_sync_sg_for_device on unmapped address. If it was mapped it is bogus as well as you can't double map it. Please describe what you're actually trying to fix and we're going to work on a proper solution, but this shot from the hip is just going to make things worse.
| |