Messages in this thread | | | From | Marco Hartmann <> | Subject | [PATCH net-next 0/1] Add genphy_c45_config_aneg() function to phy-c45.c | Date | Mon, 19 Aug 2019 17:52:47 +0000 |
| |
Currently, using a Clause 45 Phy with the "Generic Clause 45 PHY" driver leads to a warning, similar to the one below, as soon as the interface is brought up.
------------[ cut here ]------------ WARNING: CPU: 2 PID: 146 at drivers/net/phy/phy.c:736 phy_error+0x2c/0x64 Modules linked in: fec CPU: 2 PID: 146 Comm: kworker/2:1 Not tainted 5.3.0-rc3-NETNEXT-00816-g48e924c73178 #20 Hardware name: Freescale i.MX6 Quad/DualLite (Device Tree) Workqueue: events_power_efficient phy_state_machine Backtrace: ...
This happens, because the Genphy driver does not provide a config_aneg() func, so that phy_start_aneg() ultimately fails such that phy_error() is called, producing the above warning.
This patch adds the function genphy_c45_config_aneg(), which allows phy_start_aneg() to work correctly for C45 phys.
Marco Hartmann (1): Add genphy_c45_config_aneg() function to phy-c45.c
drivers/net/phy/phy-c45.c | 26 ++++++++++++++++++++++++++ drivers/net/phy/phy.c | 2 +- include/linux/phy.h | 1 + 3 files changed, 28 insertions(+), 1 deletion(-)
-- 2.7.4
| |