Messages in this thread | | | Subject | Re: [PATCH] virtio-net: lower min ring num_free for efficiency | From | Jason Wang <> | Date | Thu, 15 Aug 2019 11:01:00 +0800 |
| |
On 2019/8/14 上午10:06, ? jiang wrote: > This change lowers ring buffer reclaim threshold from 1/2*queue to budget > for better performance. According to our test with qemu + dpdk, packet > dropping happens when the guest is not able to provide free buffer in > avail ring timely with default 1/2*queue. The value in the patch has been > tested and does show better performance.
Please add your tests setup and result here.
Thanks
> > Signed-off-by: jiangkidd <jiangkidd@hotmail.com> > --- > drivers/net/virtio_net.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c > index 0d4115c9e20b..bc08be7925eb 100644 > --- a/drivers/net/virtio_net.c > +++ b/drivers/net/virtio_net.c > @@ -1331,7 +1331,7 @@ static int virtnet_receive(struct receive_queue *rq, int budget, > } > } > > - if (rq->vq->num_free > virtqueue_get_vring_size(rq->vq) / 2) { > + if (rq->vq->num_free > min((unsigned int)budget, virtqueue_get_vring_size(rq->vq)) / 2) { > if (!try_fill_recv(vi, rq, GFP_ATOMIC)) > schedule_delayed_work(&vi->refill, 0); > }
| |